Refactor calendar methods into util class#3088
Merged
khassel merged 13 commits intoMagicMirrorOrg:developfrom Apr 9, 2023
Merged
Refactor calendar methods into util class#3088khassel merged 13 commits intoMagicMirrorOrg:developfrom
khassel merged 13 commits intoMagicMirrorOrg:developfrom
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #3088 +/- ##
===========================================
- Coverage 27.90% 26.02% -1.88%
===========================================
Files 52 53 +1
Lines 11574 11583 +9
===========================================
- Hits 3230 3015 -215
- Misses 8344 8568 +224
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
khassel
approved these changes
Apr 8, 2023
rejas
force-pushed
the
cleanup/calendar_utils
branch
2 times, most recently
from
4df662c to
1aee2d8
Compare
added 12 commits
April 9, 2023 09:20
no need for that... adjust tests
rejas
force-pushed
the
cleanup/calendar_utils
branch
from
e641456 to
224653f
Compare
khassel
approved these changes
Apr 9, 2023
Collaborator
Author
|
would then be ready to merge @khassel :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored some methods in calendar module: