Merged
Conversation
It will have reached end-of-life by the next release.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #3085 +/- ##
===========================================
+ Coverage 27.51% 27.55% +0.04%
===========================================
Files 52 52
Lines 11573 11573
===========================================
+ Hits 3184 3189 +5
+ Misses 8389 8384 -5 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator
Author
|
Interesting that the tests work with v16 and 19, but not with v18. The v18 test works locally for me. |
Collaborator
tests are still (or again) not stable ... unrelated to your PR ... (started the v18 test again and it passed) |
khassel
approved these changes
Apr 7, 2023
rejas
approved these changes
Apr 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node v14 will have reached end-of-life by the next release.
From April 18th we can use node v20 instead of v19 for testing.