update dependencies and main.css to match new stylelint rules#3067
update dependencies and main.css to match new stylelint rules#3067rejas merged 2 commits intoMagicMirrorOrg:developfrom
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #3067 +/- ##
===========================================
+ Coverage 23.05% 27.55% +4.49%
===========================================
Files 52 52
Lines 11566 11566
===========================================
+ Hits 2667 3187 +520
+ Misses 8899 8379 -520 see 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
KristjanESPERANTO
left a comment
KristjanESPERANTO
left a comment
There was a problem hiding this comment.
Interesting, the css test works for me without an adjustment of the css file (with new dependencies). So I don't see any new rule.
But switching to inset is fine anyway, I think.
|
strange, got this: > stylelint 'css/main.css' 'fonts/*.css' 'modules/default/**/*.css' 'vendor/*.css' --config .stylelintrc.json
css/main.css
177:3 ✖ Expected shorthand property "inset" declaration-block-no-redundant-longhand-properties
1 problem (1 error, 0 warnings) |
|
I should think once more before I write. I must have forgotten |
4 participants
On
developmy css test failed because I was already on newest dependencies.main.cssbecause of stylelint issue