Issue#3064 html alert title message#3065
Merged
rejas merged 9 commits intoMagicMirrorOrg:developfrom Mar 19, 2023
Merged
Conversation
Fix alert nunjunks template to handle title and message as HTML
Fix nunjucks notification template to handle title and message as HTML
Fix default alert module to render HTML for title and message
Default to using html if 'titleType' and 'messageType' are null
Default to using html if 'titleType' and 'messageType' are null
Change '|' to use 'or'
Change '|' to use 'or'
Reversing logic to always render HTML unless type is set to 'text'
Reversing logic to always render HTML unless type is set to 'text'
Contributor
Author
|
Documentation also updated at: https://github.com/nfogal/MagicMirror-Documentation/pull/1 |
khassel
approved these changes
Mar 14, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #3065 +/- ##
===========================================
+ Coverage 23.02% 23.10% +0.07%
===========================================
Files 52 52
Lines 11582 11582
===========================================
+ Hits 2667 2676 +9
+ Misses 8915 8906 -9 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rejas
approved these changes
Mar 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3064
e.g.
Display Text:
this.sendNotification('SHOW_ALERT', {type: "notification", title: "<u>YoLink LeakSensor</u>", titleType: "text", message: "<b>" + deviceName + "</b> reported an alarm that needs attention.", messageType: "text"});Display HTML:
this.sendNotification('SHOW_ALERT', {type: "notification", title: "<u>YoLink LeakSensor</u>", message: "<b>" + deviceName + "</b> reported an alarm that needs attention."});