fix e2e tests (failed after async changes)#3063
Merged
rejas merged 1 commit intoMagicMirrorOrg:developfrom Mar 12, 2023
Merged
Conversation
…wsfeed tests last, allow unit tests to parallel
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #3063 +/- ##
===========================================
+ Coverage 23.00% 23.10% +0.10%
===========================================
Files 52 52
Lines 11578 11582 +4
===========================================
+ Hits 2663 2676 +13
+ Misses 8915 8906 -9
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
KristjanESPERANTO
approved these changes
Mar 11, 2023
Collaborator
KristjanESPERANTO
left a comment
KristjanESPERANTO
left a comment
There was a problem hiding this comment.
Nice! Looks good to me.
rejas
approved these changes
Mar 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by running calendar and newsfeed tests last.
Additional change: allow unit tests to run parallel
This is no fix of the real issue of calendar and newsfeed tests but I moved them to the end of the tests so other tests are not failing anymore.
There are coming follow up PR's for the real fixes (when I find the culprits).
With these change we can stay with the async changes done by @rejas and #3060 is obsolete.