Skip to content

Fix empty news feed stopping the feed from ever updating again#3062

Merged
rejas merged 2 commits intoMagicMirrorOrg:developfrom
buxxi:fix-empty-newsfeeds
Mar 11, 2023
Merged

Fix empty news feed stopping the feed from ever updating again#3062
rejas merged 2 commits intoMagicMirrorOrg:developfrom
buxxi:fix-empty-newsfeeds

Conversation

@buxxi
Copy link
Contributor

@buxxi buxxi commented Mar 11, 2023

If a news feed returns an empty file it will cause the feed to only show the previous entries forever since no new fetch is scheduled.

@codecov-commenter
Copy link

Codecov Report

Merging #3062 (ce59c5f) into develop (1b2785c) will increase coverage by 0.10%.
The diff coverage is 62.50%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop    #3062      +/-   ##
===========================================
+ Coverage    23.00%   23.10%   +0.10%     
===========================================
  Files           52       52              
  Lines        11578    11582       +4     
===========================================
+ Hits          2663     2676      +13     
+ Misses        8915     8906       -9     
Impacted Files Coverage Δ
modules/default/weather/providers/openmeteo.js 0.00% <0.00%> (ø)
modules/default/newsfeed/newsfeedfetcher.js 82.51% <100.00%> (+0.39%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rejas rejas merged commit beea754 into MagicMirrorOrg:develop Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants