Skip to content

Undo async patches#3060

Closed
rejas wants to merge 6 commits intoMagicMirrorOrg:developfrom
rejas:undo_async
Closed

Undo async patches#3060
rejas wants to merge 6 commits intoMagicMirrorOrg:developfrom
rejas:undo_async

Conversation

@rejas
Copy link
Collaborator

@rejas rejas commented Mar 7, 2023

As discussed in #3050 this PR undoes all async patches until we get the timing issues (or whatever causes the tests to fail) sorted out.

@rejas rejas marked this pull request as draft March 7, 2023 21:25
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Merging #3060 (fe573c8) into develop (1b2785c) will increase coverage by 4.52%.
The diff coverage is 46.76%.

❗ Current head fe573c8 differs from pull request most recent head 137bbff. Consider uploading reports for the commit 137bbff to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop    #3060      +/-   ##
===========================================
+ Coverage    23.00%   27.52%   +4.52%     
===========================================
  Files           52       52              
  Lines        11578    11580       +2     
===========================================
+ Hits          2663     3187     +524     
+ Misses        8915     8393     -522     
Impacted Files Coverage Δ
js/electron.js 0.00% <0.00%> (ø)
js/loader.js 0.00% <0.00%> (ø)
js/main.js 0.00% <0.00%> (ø)
modules/default/alert/alert.js 0.00% <0.00%> (ø)
modules/default/compliments/compliments.js 0.00% <0.00%> (ø)
modules/default/weather/providers/openmeteo.js 0.00% <0.00%> (ø)
serveronly/index.js 0.00% <0.00%> (ø)
js/server.js 95.79% <66.66%> (-0.11%) ⬇️
js/module.js 70.14% <70.00%> (+70.14%) ⬆️
js/app.js 82.36% <89.87%> (+1.47%) ⬆️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@KristjanESPERANTO
Copy link
Collaborator

It's a shame about the work you put in. Maybe it would be a good idea after the new release to slowly convert one part after the other to async? Maybe not all cause the problem and we can find out which parts are critical.

@khassel
Copy link
Collaborator

khassel commented Mar 9, 2023

yes, but its not reverted yet and if we have to its not lost, we have to find the real issue which seems to be difficult, see also my comment here, if you have an idea let us know ...

@KristjanESPERANTO
Copy link
Collaborator

@khassel Is that (#3061) any help?

rejas pushed a commit that referenced this pull request Mar 12, 2023
by running calendar and newsfeed tests last.

Additional change: allow unit tests to run parallel

This is no fix of the real issue of calendar and newsfeed tests but I
moved them to the end of the tests so other tests are not failing
anymore.

There are coming follow up PR's for the real fixes (when I find the
culprits).

With these change we can stay with the async changes done by @rejas and
#3060 is obsolete.
@rejas rejas closed this Mar 12, 2023
@rejas rejas deleted the undo_async branch August 20, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants