Convert translator callbacks to async/await#3048
Merged
khassel merged 4 commits intoMagicMirrorOrg:developfrom Feb 21, 2023
Merged
Convert translator callbacks to async/await#3048khassel merged 4 commits intoMagicMirrorOrg:developfrom
khassel merged 4 commits intoMagicMirrorOrg:developfrom
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #3048 +/- ##
===========================================
+ Coverage 22.90% 22.93% +0.02%
===========================================
Files 52 52
Lines 11546 11533 -13
===========================================
Hits 2645 2645
+ Misses 8901 8888 -13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
khassel
approved these changes
Feb 21, 2023
Collaborator
|
can this be merged or will you wait for other approvals? |
Collaborator
Author
If the tests run through it can be merged right away |
rejas
pushed a commit
to rejas/MagicMirror
that referenced
this pull request
Mar 7, 2023
)" This reverts commit 2b792cd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.