Show events of a configurable amount of past days#3046
Show events of a configurable amount of past days#3046rejas merged 5 commits intoMagicMirrorOrg:developfrom
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #3046 +/- ##
===========================================
+ Coverage 22.91% 23.01% +0.09%
===========================================
Files 52 52
Lines 11543 11577 +34
===========================================
+ Hits 2645 2664 +19
- Misses 8898 8913 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rejas
left a comment
rejas
left a comment
There was a problem hiding this comment.
Nice PR, just would be nice to have some tests
| { | ||
| "LOADING": "Loading …", | ||
|
|
||
| "YESTERDAY": "Yesterday", |
There was a problem hiding this comment.
So, what are english displays showing then?
There was a problem hiding this comment.
They will show "Yesterday" like "Today" for today
…AfterTomorrow" css classes in calender_spec.js
|
I'm not fond of this pr. we should leave this to extension modules and not try to jam past events into the default display. have enough calendar problems as it is |
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "LOADING": "Besig om te laai …", | |||
|
|
|||
There was a problem hiding this comment.
Is it intentional that some languages are missing DAYBEFOREYESTERDAY?
There was a problem hiding this comment.
There is no useful translation for "DAYBEFOREYESTERDAY" and "DAYAFTERTOMORROW" in some languages. The calendar module takes care of these exceptions for "DAYAFTERTOMORROW" already.
I adapted the mechanism to "DAYBEFOREYESTERDAY"
There was a problem hiding this comment.
Ah okay, thanks for the explanation!
I think this PR is a useful addition to the standard module 🙂
|
I agree with you that the calendar module is bloated / full-of-old-code etc But this PR seems small and straightforward enough IMO to be merged. No weird edge cases or so... I am in favor of merging. Whats your take @khassel ? |
|
It's a valid usecase so I will not block a merge. But on the other side it does not simplify the code. Because it is implemented as a new option it hopefully will not increase support. |
|
it will increase support. layout, colors,. blah blah.. I don't see how a few days in the past helps the birthday list issue... |
|
Hi, i can understand the concerns about increasing amount of support with increasing amount of features. My birthday list issue is solved with this changes as anything else is styling i can do with CSS. |
|
based on past experience. more than one someone will want these past events formatted differently than current. and will want more, and might want them after the upcoming |
|
@sdetweil I wrote a transformer for MMM-CalenderExt3Agend today and did some hardcore CSS restyling to the module. As the module displays past events in default it is okay for me if do not want to merge the pull request. But i will need to open a issue as the default calender module broadcasts the birthday as monthly events instead of yearly. |
|
monthly vs yearly. but they are yearly..... why mangle the data |
|
Merging it since the majority seems to be in favor of it. |
|
Could you please create a PR with the next options for the documentation page https://github.com/MichMich/MagicMirror-Documentation |
6 participants
Hi,
want to include a birthday calendar to my mirror which shows upcoming birthdays and as a reminder birthdays of the last two days.
I used MMM-CalendarExt2 for this job in the past but the module is not supported any more and very complicated to configure.
I managed to style the default calendar module to my needs but what i am missing is to display already past events within a configurable time range.
I included the translations of "YESTERDAY" and "DAYBEFOREYESTERDAY" to all translation files and modified the code to accept a new option
pastDaysCountwhich controls of how many days past events should be displayed.