Skip to content

Update coverage and jest settings#3038

Merged
khassel merged 4 commits intoMagicMirrorOrg:developfrom
rejas:misc/coverage
Feb 16, 2023
Merged

Update coverage and jest settings#3038
khassel merged 4 commits intoMagicMirrorOrg:developfrom
rejas:misc/coverage

Conversation

@rejas
Copy link
Collaborator

@rejas rejas commented Feb 16, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Merging #3038 (8825255) into develop (e24dfa6) will increase coverage by 0.07%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop    #3038      +/-   ##
===========================================
+ Coverage    22.87%   22.95%   +0.07%     
===========================================
  Files           52       52              
  Lines        11541    11541              
===========================================
+ Hits          2640     2649       +9     
+ Misses        8901     8892       -9     
Impacted Files Coverage Δ
modules/default/updatenotification/node_helper.js 90.27% <0.00%> (+12.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rejas rejas marked this pull request as ready for review February 16, 2023 08:54
@khassel
Copy link
Collaborator

khassel commented Feb 16, 2023

I'm not happy with the jest changes because when I now debug one test I have to add --verbose to it.

So why not revert the jest changes and add --verbose false to the "test:coverage" test?

@rejas
Copy link
Collaborator Author

rejas commented Feb 16, 2023

I'm not happy with the jest changes because when I now debug one test I have to add --verbose to it.

Thats why I added the verbose flag to the specialized test scripts (test:e2e etc) so that one can use them and get the verbose stuff (they are not used anywhere else as far as I can see=. Would that be okay?

@khassel
Copy link
Collaborator

khassel commented Feb 16, 2023

As already mentioned before please don't change verbose: true, but instead use "test:coverage": "NODE_ENV=test jest --coverage -i --forceExit --verbose false", for the one test where you don't want to see the verbose stuff.

In all other tests we want to have the verbose stuff and also when testing locally, e.g. running one test with npx jest tests/unit/modules/default/utils_spec.js I don't want to add the --verbose flag.

@rejas
Copy link
Collaborator Author

rejas commented Feb 16, 2023

Undid the changes :-)

@khassel
Copy link
Collaborator

khassel commented Feb 16, 2023

Thanks!

@khassel khassel merged commit 65aa1b0 into MagicMirrorOrg:develop Feb 16, 2023
@rejas rejas deleted the misc/coverage branch February 16, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants