Skip to content

Test PR against master#3036

Closed
rejas wants to merge 5 commits intoMagicMirrorOrg:masterfrom
rejas:misc/test_master
Closed

Test PR against master#3036
rejas wants to merge 5 commits intoMagicMirrorOrg:masterfrom
rejas:misc/test_master

Conversation

@rejas
Copy link
Collaborator

@rejas rejas commented Feb 15, 2023

Hello and thank you for wanting to contribute to the MagicMirror² project

Please make sure that you have followed these 4 rules before submitting your Pull Request:

  1. Base your pull requests against the develop branch.

  2. Include these infos in the description:

  • Does the pull request solve a related issue?
  • If so, can you reference the issue like this Fixes #<issue_number>?
  • What does the pull request accomplish? Use a list if needed.
  • If it includes major visual changes please add screenshots.
  1. Please run npm run lint:prettier before submitting so that
    style issues are fixed.

  2. Don't forget to add an entry about your changes to
    the CHANGELOG.md file.

Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of develop before creating a
pull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.

Thanks again and have a nice day!

@rejas rejas closed this Feb 16, 2023
@rejas rejas deleted the misc/test_master branch February 16, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant