Skip to content

Convert app-start/-stop callbacks to async/await#3035

Merged
khassel merged 6 commits intoMagicMirrorOrg:developfrom
rejas:misc/async_start_loadconfig
Feb 22, 2023
Merged

Convert app-start/-stop callbacks to async/await#3035
khassel merged 6 commits intoMagicMirrorOrg:developfrom
rejas:misc/async_start_loadconfig

Conversation

@rejas
Copy link
Collaborator

@rejas rejas commented Feb 12, 2023

supersedes #3027 and just touches the start/stop calls.

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2023

Codecov Report

Merging #3035 (0afd715) into develop (2b792cd) will increase coverage by 0.16%.
The diff coverage is 75.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop    #3035      +/-   ##
===========================================
+ Coverage    22.95%   23.11%   +0.16%     
===========================================
  Files           52       52              
  Lines        11567    11590      +23     
===========================================
+ Hits          2655     2679      +24     
+ Misses        8912     8911       -1     
Impacted Files Coverage Δ
js/electron.js 0.00% <0.00%> (ø)
serveronly/index.js 0.00% <0.00%> (ø)
js/app.js 81.13% <81.81%> (-1.24%) ⬇️
modules/default/updatenotification/node_helper.js 90.27% <0.00%> (+12.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rejas rejas force-pushed the misc/async_start_loadconfig branch 5 times, most recently from 0f03b66 to c581a42 Compare February 19, 2023 20:38
@rejas rejas force-pushed the misc/async_start_loadconfig branch 2 times, most recently from c6805aa to 9bbb6cf Compare February 20, 2023 19:13
@rejas rejas force-pushed the misc/async_start_loadconfig branch 2 times, most recently from 567733a to 9c4fa24 Compare February 21, 2023 22:06
@rejas rejas marked this pull request as ready for review February 21, 2023 22:08
@rejas rejas changed the title Convert start loadconfig callbacks to async/await Convert app-start/-stop callbacks to async/await Feb 21, 2023
@khassel khassel merged commit fe0b915 into MagicMirrorOrg:develop Feb 22, 2023
@rejas rejas deleted the misc/async_start_loadconfig branch February 22, 2023 18:31
rejas pushed a commit to rejas/MagicMirror that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants