Translation Notification module#3029
Closed
tomzt wants to merge 2 commits intoMagicMirrorOrg:masterfrom
Closed
Conversation
Create th.json and Translate from English tom Thai.
Collaborator
|
Please base your PR against the develo branch (like it is mentioned in the template) |
rejas
requested changes
Feb 7, 2023
Collaborator
rejas
left a comment
rejas
left a comment
There was a problem hiding this comment.
please base against develop
Merged
khassel
pushed a commit
that referenced
this pull request
Feb 20, 2023
actually add it to the tanslation list and also add the alert translations from #3029 since the OP didnt seem to work on it (yet) --------- Co-authored-by: veeck <[email protected]> Co-authored-by: Suthep Yonphimai <[email protected]>
Collaborator
|
Closing this since it got merged via #3044 Thx for your original PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello and thank you for wanting to contribute to the MagicMirror² project
Please make sure that you have followed these 4 rules before submitting your Pull Request:
Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of
developbefore creating apull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.
Thanks again and have a nice day!