Point wind arrow in the direction the wind is flowing#3022
Merged
rejas merged 1 commit intoMagicMirrorOrg:developfrom Jan 22, 2023
MagMar94:bugfix/fix-weather-arrow-direction
Merged
Point wind arrow in the direction the wind is flowing#3022rejas merged 1 commit intoMagicMirrorOrg:developfrom MagMar94:bugfix/fix-weather-arrow-direction
rejas merged 1 commit intoMagicMirrorOrg:developfrom
MagMar94:bugfix/fix-weather-arrow-direction
Conversation
The previous implementation had the arrow pointing in to the wind. When the wind blows from the north (0 degrees), the arrow should point straight down. When the wind blow from the south (180 degrees), the arrow should point straight up.
rejas
approved these changes
Jan 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3019
The previous implementation had the arrow pointing in to the wind. When the wind blows from the north (0 degrees), the arrow should point straight down. In other words, no rotation of the arrow-down symbol. When the wind blows from the south (180 degrees), the arrow should point straight up (I.e. the arrow down symbol rotated 180 degrees).