Codecov Report

Merging #3020 (6605d68) into develop (cd4ba42) will increase coverage by 0.07%.
The diff coverage is 2.70%.

@@             Coverage Diff             @@
##           develop    #3020      +/-   ##
===========================================
+ Coverage    21.76%   21.84%   +0.07%     
===========================================
  Files           52       52              
  Lines        11441    11441              
===========================================
+ Hits          2490     2499       +9     
+ Misses        8951     8942       -9     

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Will have a look at this later when home (and if there are tests for this) Have you checked if every provider handles wind direction the same?

Have you checked if every provider handles wind direction the same?

No, but I only changed the variable assignment in the Yr-provider.

I renamed the variable for everyone to make It easier to understand what value the weather module expects. If a provider returns the wrong value it will result in wrong cardinal directions.

I missed this when I implemented the provider, because I matched the arrow (showWindDirectionAsArrow) to what was displayed on Yr.no with the mirror. On Yr (and other weather services) arrows points in the direction the wind is blowing, but the current MM-implementation points to where the wind is blowing from. I will fix this in another PR referencing #3019. I created the issue to get some feedback before I fix it.