Skip to content

added error message if <modulename>.js file is missing …#3015

Merged
rejas merged 1 commit intoMagicMirrorOrg:developfrom
khassel:module_error
Jan 26, 2023
Merged

added error message if <modulename>.js file is missing …#3015
rejas merged 1 commit intoMagicMirrorOrg:developfrom
khassel:module_error

Conversation

@khassel
Copy link
Collaborator

@khassel khassel commented Jan 17, 2023

… in module folder to get a hint in the logs

fixes #2403

@codecov-commenter
Copy link

Codecov Report

Merging #3015 (6b2894b) into develop (4244c05) will increase coverage by 0.11%.
The diff coverage is 75.00%.

@@             Coverage Diff             @@
##           develop    #3015      +/-   ##
===========================================
+ Coverage    21.76%   21.87%   +0.11%     
===========================================
  Files           52       52              
  Lines        11441    11449       +8     
===========================================
+ Hits          2490     2505      +15     
+ Misses        8951     8944       -7     
Impacted Files Coverage Δ
js/app.js 82.22% <75.00%> (-0.19%) ⬇️
modules/default/updatenotification/node_helper.js 90.27% <0.00%> (+12.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rejas rejas merged commit 157e74c into MagicMirrorOrg:develop Jan 26, 2023
@khassel khassel deleted the module_error branch February 6, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants