Add (in Alert module) templateName parameter#3009
Merged
rejas merged 3 commits intoMagicMirrorOrg:developfrom Jan 26, 2023
Merged
Add (in Alert module) templateName parameter#3009rejas merged 3 commits intoMagicMirrorOrg:developfrom
rejas merged 3 commits intoMagicMirrorOrg:developfrom
Conversation
Collaborator
|
@rajniszp could you change the title to add, in alert module |
rajniszp
changed the title
Contributor
Author
|
Sure, changed |
Codecov Report
@@ Coverage Diff @@
## develop #3009 +/- ##
===========================================
+ Coverage 21.76% 21.84% +0.07%
===========================================
Files 52 52
Lines 11439 11439
===========================================
+ Hits 2490 2499 +9
+ Misses 8949 8940 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple change allows to use your own templates (under "templates" directory). The parameter
templateNameis optional (ignored on falsy value - undefined, null, empty string, etc.) and independent oftype.