Skip to content

add Pirate Weather as new weather provider#3006

Merged
rejas merged 1 commit intoMagicMirrorOrg:developfrom
khassel:pirate
Jan 15, 2023
Merged

add Pirate Weather as new weather provider#3006
rejas merged 1 commit intoMagicMirrorOrg:developfrom
khassel:pirate

Conversation

@khassel
Copy link
Collaborator

@khassel khassel commented Jan 14, 2023

@codecov-commenter
Copy link

Codecov Report

Merging #3006 (df310d7) into develop (d2327d3) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3006      +/-   ##
===========================================
- Coverage    22.03%   21.84%   -0.19%     
===========================================
  Files           51       52       +1     
  Lines        11301    11439     +138     
===========================================
+ Hits          2490     2499       +9     
- Misses        8811     8940     +129     
Impacted Files Coverage Δ
modules/default/weather/providers/pirateweather.js 0.00% <0.00%> (ø)
modules/default/updatenotification/node_helper.js 90.27% <0.00%> (+12.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rejas rejas merged commit 8d9f132 into MagicMirrorOrg:develop Jan 15, 2023
@rejas
Copy link
Collaborator

rejas commented Jan 15, 2023

documentation PR will be coming I assume?

@khassel
Copy link
Collaborator Author

khassel commented Jan 15, 2023

@khassel khassel deleted the pirate branch January 17, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants