updatenotification: only notify mm-repo for master if tag present#3004
Merged
rejas merged 2 commits intoMagicMirrorOrg:developfrom Jan 26, 2023
Merged
updatenotification: only notify mm-repo for master if tag present#3004rejas merged 2 commits intoMagicMirrorOrg:developfrom
rejas merged 2 commits intoMagicMirrorOrg:developfrom
Conversation
…ications if there is no new release tag (only for `master`)
Codecov Report
@@ Coverage Diff @@
## develop #3004 +/- ##
===========================================
+ Coverage 21.94% 22.23% +0.29%
===========================================
Files 51 51
Lines 11297 11324 +27
===========================================
+ Hits 2479 2518 +39
+ Misses 8818 8806 -12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator
|
Looks good to me! 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see discussion here: #2991 (comment)
I still see a need for updating
masterin special cases (e.g. correct errors in README.md which would otherwise be present up to 3 month until next release) so with this PR only for MagicMirror repo and only formasterbranch updatenotifications are only triggered if at least one of the new commits has a tag.May @MichMich must decide if this is wanted.