Skip to content

Prevent electron flashing white screen on startup#3001

Merged
rejas merged 1 commit intoMagicMirrorOrg:developfrom
khassel:electron_white
Jan 26, 2023
Merged

Prevent electron flashing white screen on startup#3001
rejas merged 1 commit intoMagicMirrorOrg:developfrom
khassel:electron_white

Conversation

@khassel
Copy link
Collaborator

@khassel khassel commented Jan 11, 2023

see #1919

thanks @dfanica for providing the solution in this comment

tested this on a pi4 with bullseye 32-bit and 64-bit

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2023 •
edited
Loading

Codecov Report

Merging #3001 (1d143d2) into develop (877f8ad) will increase coverage by 0.15%.
The diff coverage is 54.54%.

@@             Coverage Diff             @@
##           develop    #3001      +/-   ##
===========================================
+ Coverage    21.94%   22.09%   +0.15%     
===========================================
  Files           51       51              
  Lines        11297    11308      +11     
===========================================
+ Hits          2479     2499      +20     
+ Misses        8818     8809       -9
Impacted Files Coverage Δ
js/electron.js 0.00% <0.00%> (ø)
...s/default/updatenotification/updatenotification.js 0.00% <0.00%> (ø)
modules/default/updatenotification/git_helper.js 90.53% <100.00%> (+0.11%) ⬆️
modules/default/updatenotification/node_helper.js 90.27% <100.00%> (+23.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rejas
Copy link
Collaborator

rejas commented Jan 11, 2023

I am a little confused, the comment you mention specifies to remove the fullscreen option.

@khassel
Copy link
Collaborator Author

khassel commented Jan 11, 2023

yes, he mentioned to remove fullscreen but is instead doing "manual" fullscreen in "ready-to-show" event.

That was not necassary in my tests, it was sufficient to add the "transparent" option. Additionally I replaced "autoHideMenuBar" with "frame" (and "hasShadow").

KristjanESPERANTO
KristjanESPERANTO reviewed Jan 11, 2023
View reviewed changes
dfanica
dfanica reviewed Jan 13, 2023
View reviewed changes
@khassel khassel marked this pull request as draft January 13, 2023 17:50
dfanica
dfanica reviewed Jan 13, 2023
View reviewed changes
@khassel khassel linked an issue Jan 13, 2023 that may be closed by this pull request
Electron shows white screen during the MM start #1919
Closed
@khassel khassel marked this pull request as ready for review January 13, 2023 20:56
@khassel
Copy link
Collaborator Author

khassel commented Jan 26, 2023

@rejas so if no one else wants to test this we should merge it for getting feedback when it is on develop

@rejas
Copy link
Collaborator

rejas commented Jan 26, 2023

Tested it myself now, lets have a go on develop :-) Sometimes I am wondering how many testers we have there anyway....

@rejas rejas merged commit 42d42ef into MagicMirrorOrg:develop Jan 26, 2023
@dfanica
Copy link

dfanica commented Jan 27, 2023

I have build develop on my mirror and it seems to work as expected 👍

@khassel khassel deleted the electron_white branch February 6, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KristjanESPERANTO KristjanESPERANTO KristjanESPERANTO left review comments

+1 more reviewer

@dfanica dfanica dfanica left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Electron shows white screen during the MM start

5 participants

@khassel @codecov-commenter @rejas @dfanica @KristjanESPERANTO