Refactor mock-data for weather-tests generation#3000
Merged
khassel merged 5 commits intoMagicMirrorOrg:developfrom Jan 11, 2023
Merged
Refactor mock-data for weather-tests generation#3000khassel merged 5 commits intoMagicMirrorOrg:developfrom
khassel merged 5 commits intoMagicMirrorOrg:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3000 +/- ##
===========================================
+ Coverage 21.95% 22.02% +0.06%
===========================================
Files 51 51
Lines 11292 11297 +5
===========================================
+ Hits 2479 2488 +9
+ Misses 8813 8809 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rejas
changed the title
khassel
approved these changes
Jan 10, 2023
Collaborator
|
@rejas for me ready to merge, tell me if you want to wait for other comments/reviews ... |
Collaborator
Author
|
@khassel go for it :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the mock data generation for the tests so we can use plain JSON files for the data and read it in a more general way.
Comments welcome!