improve electron tests (avoid errors in github workflows)#2977
Merged
rejas merged 3 commits intoMagicMirrorOrg:developfrom Dec 12, 2022
Merged
improve electron tests (avoid errors in github workflows)#2977rejas merged 3 commits intoMagicMirrorOrg:developfrom
rejas merged 3 commits intoMagicMirrorOrg:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2977 +/- ##
===========================================
+ Coverage 22.75% 22.85% +0.09%
===========================================
Files 51 51
Lines 10895 10887 -8
===========================================
+ Hits 2479 2488 +9
+ Misses 8416 8399 -17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator
Author
|
the failed codecov test is unrelated to this PR |
Collaborator
|
Rerunning fixed that. So this would be ready from your side? |
Collaborator
Author
|
yes (did also a rerun so may a temporary problem). |
rejas
approved these changes
Dec 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix electron tests failing sometimes in github workflow.