Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2954 +/- ##
===========================================
- Coverage 65.28% 65.21% -0.08%
===========================================
Files 14 14
Lines 726 733 +7
===========================================
+ Hits 474 478 +4
- Misses 252 255 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
khassel
force-pushed
the
collaboration
branch
from
2d44d1b to
0a37da3
Compare
KristjanESPERANTO
approved these changes
Oct 31, 2022
Collaborator
KristjanESPERANTO
left a comment
KristjanESPERANTO
left a comment
There was a problem hiding this comment.
Even though I'm not an official reviewer, it looks good to me too 🙂
Collaborator
|
Good morning @sdetweil are you fine with these ? |
Collaborator
|
by the way, might it make sense to add @MichMich to the discurs channel too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As already discussed here the first shot of the collaboration rules.
We can discuss this in the comments until ready to merge.