Support for configuring FontAwesome class in calendar-module:#2949
Merged
rejas merged 4 commits intoMagicMirrorOrg:developfrom Oct 16, 2022
MagMar94:bugfix/facebook-icon-does-not-work
Merged
Support for configuring FontAwesome class in calendar-module:#2949rejas merged 4 commits intoMagicMirrorOrg:developfrom MagMar94:bugfix/facebook-icon-does-not-work
rejas merged 4 commits intoMagicMirrorOrg:developfrom
MagMar94:bugfix/facebook-icon-does-not-work
Conversation
added 3 commits
October 16, 2022 18:29
Some symbols require a different class name than the hard coded "fas fa-fw fa-". The facebook symbol, for instance, requires "fab fa-".
…icon-does-not-work
Collaborator
|
Thanks, but could you check why the tests are failing and fix them? |
Contributor
Author
Done ✅ |
Codecov Report
@@ Coverage Diff @@
## develop #2949 +/- ##
========================================
Coverage 64.06% 64.06%
========================================
Files 9 9
Lines 295 295
========================================
Hits 189 189
Misses 106 106 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rejas
approved these changes
Oct 16, 2022
Collaborator
|
Looks good. COuld you also create a PR for this new option in the Doc repo (https://github.com/MichMich/MagicMirror-Documentation/) for the calendar page (https://docs.magicmirror.builders/modules/calendar.html#configuration-options) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some icons in FontAwesome, like the Facebook-logo, requires a different class than
fas fa-fw fa-. Added support for specifying theclassName: