added new electron tests supporting date mocking#2947
Merged
rejas merged 2 commits intoMagicMirrorOrg:developfrom Oct 17, 2022
Merged
added new electron tests supporting date mocking#2947rejas merged 2 commits intoMagicMirrorOrg:developfrom
rejas merged 2 commits intoMagicMirrorOrg:developfrom
Conversation
…m `e2e` to `electron` because of date mocking, removed mock stuff from compliments module
Codecov Report
@@ Coverage Diff @@
## develop #2947 +/- ##
===========================================
+ Coverage 64.06% 65.28% +1.22%
===========================================
Files 9 14 +5
Lines 295 726 +431
===========================================
+ Hits 189 474 +285
- Misses 106 252 +146
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rejas
requested changes
Oct 16, 2022
rejas
approved these changes
Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first PR for #2942
e2etoelectronbecause of date mocking