Ensure updatenotification module isn't shown when local is *ahead* of remote#2943
Merged
khassel merged 2 commits intoMagicMirrorOrg:developfrom Oct 12, 2022
Merged
Ensure updatenotification module isn't shown when local is *ahead* of remote#2943khassel merged 2 commits intoMagicMirrorOrg:developfrom
khassel merged 2 commits intoMagicMirrorOrg:developfrom
Conversation
added 2 commits
October 12, 2022 16:42
… remote Update Regex to match status info. Only notify when repo's commits are 'behind'. Use Regex capturing groups to extract git info.
Forgot to run prettier after updating CHANGELOG 🤦🏼
khassel
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a small bug in the updatenotification module if a local git repo is ahead of the remote (for example I have made local commits for my personal needs).
Currently, if
git status -sbreports a status like:## master...origin/master [ahead 2]then updatenotification treats this as though it's "behind".This PR uses a single Regex to match
git status -sboutput and uses capture groups to extract info to populate thegitInfoobject to avoid needing to do string manipulation to extract this information.