fix cors problems with newsfeed articles#2940
Merged
rejas merged 3 commits intoMagicMirrorOrg:developfrom Oct 17, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2940 +/- ##
===========================================
+ Coverage 64.06% 65.28% +1.22%
===========================================
Files 9 14 +5
Lines 295 726 +431
===========================================
+ Hits 189 474 +285
- Misses 106 252 +146
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator
|
Seems to look good, but I'd like to wait for my approval until Tuesday when I return from my trip |
khassel
force-pushed
the
newsfeed-cors
branch
from
9dbd021 to
1be8f98
Compare
rejas
reviewed
Oct 13, 2022
khassel
force-pushed
the
newsfeed-cors
branch
from
1be8f98 to
b00d758
Compare
rejas
requested changes
Oct 17, 2022
Collaborator
rejas
left a comment
rejas
left a comment
There was a problem hiding this comment.
just one small jsdoc addition needed :-)
rejas
approved these changes
Oct 17, 2022
khassel
added a commit
to khassel/MagicMirror-Documentation
that referenced
this pull request
Jan 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #2840 as far as possible. There could still be errors on the embedded iframe when the owner of the site has set
X-Frame-OptionsorAccess-Control-Allow-Originheaders (as already mentioned in the docs).