Use fetch instead of XMLHttpRequest in weatherprovider#2935
Use fetch instead of XMLHttpRequest in weatherprovider#2935khassel merged 4 commits intoMagicMirrorOrg:developfrom
Conversation
also remove unused method parameter, is GET all the time
Codecov Report
@@ Coverage Diff @@
## develop #2935 +/- ##
========================================
Coverage 63.82% 63.82%
========================================
Files 9 9
Lines 293 293
========================================
Hits 187 187
Misses 106 106
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thanks for merging so quick @khassel. But could we agree that only the maintainer who created a PR merges it (of course only after one of the other maintainers approves it)? Or should we keep it strict to the "if its not really finished, do a draft PR" policy? What do you think? |
|
what is a 'draft' pr? never seen one til the other day. I don't think I should be the one merging MY submitted PR's.. |
yes, if not ready --> draft, if discussions are coming up --> draft
I was thinking of the opposite, never merge your own PR ... |
this is a PR which is not ready for merge (we have 2 at the moment here). You can open it as You can't merge |
but now you have I assume? when creating a PR you can mark it as a draft (so basically WorkInProgress)
so new rule:
|
|
I'm good with that .. (rules) I know what 'draft' means, just never seen how to select it.. |
|
o.k. for me too |
|
i just tried to create a PR, but don't see a mechanism for draft.. |
|
Existing PR see picture below:
AFAIK this property is also visible when creating a new one. |
|
I was trying to create a new one.. we shall see |
|
there it is . never noticed the dropdown!..
|
yes, its not the best UI decision from github.... |
## [2.22.0] - 2023-01-01 Thanks to: @angeldeejay, @buxxi, @dariom, @dWoolridge, @KristjanESPERANTO, @MagMar94, @naveensrinivasan, @retroflex, @SkySails and @tom. Special thanks to @khassel, @rejas and @sdetweil for taking over most (if not all) of the work on this release as project collaborators. This version would not be there without their effort. Thank you! ### Added - Added test for remoteFile option in compliments module - Added hourlyWeather functionality to Weather.gov weather provider - Removed weatherEndpoint definition from weathergov.js (not used) - Added css class names "today" and "tomorrow" for default calendar - Added Collaboration.md - Added new github action for dependency review (#2862) - Added a WeatherProvider for Open-Meteo - Added Yr as a weather provider - Added config options "ignoreXOriginHeader" and "ignoreContentSecurityPolicy" ### Removed - Removed usage of internal fetch function of node until it is more stable ### Updated - Cleaned up test directory (#2937) and jest config (#2959) - Wait for all modules to start before declaring the system ready (#2487) - Updated e2e tests (moved `done()` in helper functions) and use es6 syntax in all tests - Updated da translation - Rework weather module - Make sure smhi provider api only gets a maximum of 6 digits coordinates (#2955) - Use fetch instead of XMLHttpRequest in weatherprovider (#2935) - Reworked how weatherproviders handle units (#2849) - Use unix() method for parsing times, fix suntimes on the way (#2950) - Refactor conversion functions into utils class (#2958) - The `cors`-method in `server.js` now supports sending and recieving HTTP headers - Replace `…` by `…` - Cleanup compliments module - Updated dependencies including electron to v22 (#2903) ### Fixed - Correctly show apparent temperature in SMHI weather provider - Ensure updatenotification module isn't shown when local is _ahead_ of remote - Handle node_helper errors during startup (#2944) - Possibility to change FontAwesome class in calendar, so icons like `fab fa-facebook-square` works. - Fix cors problems with newsfeed articles (as far as possible), allow disabling cors per feed with option `useCorsProxy: false` (#2840) - Tests not waiting for the application to start and stop before starting the next test - Fix electron tests failing sometimes in github workflow - Fixed gap in clock module when displayed on the left side with displayType=digital - Fixed playwright issue by upgrading to v1.29.1 (#2969) Signed-off-by: naveen <[email protected]> Co-authored-by: Karsten Hassel <[email protected]> Co-authored-by: Malte Hallström <[email protected]> Co-authored-by: Veeck <[email protected]> Co-authored-by: veeck <[email protected]> Co-authored-by: dWoolridge <[email protected]> Co-authored-by: Johan <[email protected]> Co-authored-by: Dario Mratovich <[email protected]> Co-authored-by: Dario Mratovich <[email protected]> Co-authored-by: Magnus <[email protected]> Co-authored-by: Naveen <[email protected]> Co-authored-by: buxxi <[email protected]> Co-authored-by: Thomas Hirschberger <[email protected]> Co-authored-by: Kristjan ESPERANTO <[email protected]> Co-authored-by: Andrés Vanegas Jiménez <[email protected]>
4 participants
small update to the fetchData method to use the fetch helper instead of the old XCMLHttpRequest.
Also fixes some typos :-)