Correct apibase of weathergov weatherprovider to match documentation#2927
Merged
khassel merged 2 commits intoMagicMirrorOrg:developfrom Jan 27, 2024
Merged
Correct apibase of weathergov weatherprovider to match documentation#2927khassel merged 2 commits intoMagicMirrorOrg:developfrom
khassel merged 2 commits intoMagicMirrorOrg:developfrom
Conversation
khassel
approved these changes
Oct 3, 2022
Codecov Report
@@ Coverage Diff @@
## develop #2927 +/- ##
========================================
Coverage 65.21% 65.21%
========================================
Files 14 14
Lines 733 733
========================================
Hits 478 478
Misses 255 255 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator
|
would merge it if you resolve conflicts ... (same for #2928) |
Collaborator
Author
|
Not Sure If its OK yet to merge, since i dont want to risk breaking changes... |
Collaborator
|
looked ready, may better convert back to draft until really ready? |
Collaborator
Author
|
Made a draft, fixed conflict, will think about it later, now too late for this :-) |
Collaborator
Author
|
As for whats left to do: Think about these concerns: #2926 (comment) |
Collaborator
Author
|
Code now matches docs again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #2926