Merged
Conversation
Collaborator
Author
Collaborator
|
Thanks for your work. One favor I have to ask: Could you split the weather tests into two files, weather_current_spec and weather_forecast_spec? Would help me a lot when cleaning them up in my weather refactor later. |
rejas
reviewed
Oct 2, 2022
Codecov Report
@@ Coverage Diff @@
## develop #2923 +/- ##
========================================
Coverage 63.82% 63.82%
========================================
Files 9 9
Lines 293 293
========================================
Hits 187 187
Misses 106 106 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rejas
approved these changes
Oct 2, 2022
Collaborator
rejas
left a comment
rejas
left a comment
There was a problem hiding this comment.
Awesome! SO much cleaner now!
Collaborator
|
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use es6 syntax in all tests, split weather tests, remove callbacks