Remove old weather modules#2914
Merged
MichMich merged 2 commits intoMagicMirrorOrg:developfrom Sep 28, 2022
Merged
Conversation
khassel
force-pushed
the
remove-old-weather
branch
from
a356bd8 to
f23e604
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2914 +/- ##
========================================
Coverage 63.82% 63.82%
========================================
Files 9 9
Lines 293 293
========================================
Hits 187 187
Misses 106 106
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
KristjanESPERANTO
approved these changes
Sep 21, 2022
Collaborator
KristjanESPERANTO
left a comment
KristjanESPERANTO
left a comment
There was a problem hiding this comment.
Looks good 👍 🙂
rejas
approved these changes
Sep 21, 2022
Collaborator
|
I think the README of the new weather module could be adjusted too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modules
currentweatherandweatherforecastwere already only dummies displaying they are deprecated:"This module is deprecated since release v2.15 and removed with v2.19."
So removal was announced with v2.19, time to get rid of them ...