fix e2e tests not failing on errors#2912
Merged
MichMich merged 2 commits intoMagicMirrorOrg:developfrom Sep 28, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2912 +/- ##
========================================
Coverage 63.82% 63.82%
========================================
Files 9 9
Lines 293 293
========================================
Hits 187 187
Misses 106 106 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
khassel
force-pushed
the
e2e
branch
3 times, most recently
from
1096fda to
edea8d4
Compare
rejas
approved these changes
Sep 21, 2022
Collaborator
rejas
left a comment
rejas
left a comment
There was a problem hiding this comment.
looks good as my weather branch produces test-errors when merging your PR into it 👍
Collaborator
|
would love to see that merged soon @MichMich if you can spare the time so that I can work on fixing bugs in my weather branch. |
Collaborator
|
Sorry for the delay! Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disable recurring-event-tests of calendar: I opened a new issue calendar recurring events are broken since update to node-ical v0.15.x #2913 for this, the tests are failing at the moment and I will enable them again when the core problem is solvedalready fixed.