feat(weather/smhi): Add hourly forecasts, apparent temperature & custom location name#2902
Merged
MichMich merged 6 commits intoMagicMirrorOrg:developfrom Aug 30, 2022
SkySails:feat/smhi-weather-provider-improvements
Merged
feat(weather/smhi): Add hourly forecasts, apparent temperature & custom location name#2902MichMich merged 6 commits intoMagicMirrorOrg:developfrom SkySails:feat/smhi-weather-provider-improvements
MichMich merged 6 commits intoMagicMirrorOrg:developfrom
SkySails:feat/smhi-weather-provider-improvements
Conversation
rejas
requested changes
Aug 29, 2022
rejas
approved these changes
Aug 29, 2022
Codecov Report
@@ Coverage Diff @@
## develop #2902 +/- ##
========================================
Coverage 63.82% 63.82%
========================================
Files 9 9
Lines 293 293
========================================
Hits 187 187
Misses 106 106 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator
|
Could you fix the issue above? Thanks! |
Contributor
Author
|
@MichMich Of course! Sorry about that. |
Collaborator
|
No worries! Thanks! Merged. |
MichMich
pushed a commit
that referenced
this pull request
Oct 4, 2022
This PR addresses [this comment](48756e8#commitcomment-85772193), which points out an issue with #2902. Looks like the apparent temp calculation method was incorrectly referenced 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does not close any issues. It does, however, aim to improve the SMHI weather provider with support for hourly forecasts and apparent ("Feels like") temperature, along with the ability to customize the name of the location.