Make the calendar show the whole multi day event with how far it has progressed#2895
Merged
MichMich merged 1 commit intoMagicMirrorOrg:developfrom Aug 6, 2022
buxxi:develop
Merged
Make the calendar show the whole multi day event with how far it has progressed#2895MichMich merged 1 commit intoMagicMirrorOrg:developfrom buxxi:develop
MichMich merged 1 commit intoMagicMirrorOrg:developfrom
buxxi:develop
Conversation
Collaborator
|
I think it's a good idea to find out why the code was there in the first place. @rejas Do you have any idea? The blame points to you. :) |
Collaborator
|
Well, i didnt write the code, I merely moved it from the fetcher class into this new file... @oemel09 wrote the original code back in 2019 (6a5f022) and @kolbyjack added a fix in 2022... |
Contributor
|
As stated in my PR where I added this code back then your example would have been displayed as |
Collaborator
|
Awesome! Thanks for your feedback @oemel09 Much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made an attempt to debug issue #2685 and couldn't really find a reason to why multi day events had their start date changed to the current date. So I tried to remove it and made comparisons with and without it, using sliceMultiDayEvents=true/false.
It feels like it's wrong with sliceMultiDayEvents=true without this pull request, but since it changes the other one from "Today" to "Ends in 12 days" there might be something more that is needed to be changed? Both looks fine for me at least.