new script install-mm for simplifying mm installation#2891
Merged
MichMich merged 2 commits intoMagicMirrorOrg:developfrom Jul 28, 2022
Merged
new script install-mm for simplifying mm installation#2891MichMich merged 2 commits intoMagicMirrorOrg:developfrom
install-mm for simplifying mm installation#2891MichMich merged 2 commits intoMagicMirrorOrg:developfrom
Conversation
…s `--no-audit --no-fund --no-update-notifier` for less noise
Collaborator
Author
|
Codecov upload error seems unrelated to the changes in this PR. |
Collaborator
|
cool, will add those parms to my scripts. (install and upgrade) done |
rejas
reviewed
Jul 27, 2022
rejas
approved these changes
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by a comment of @sdetweil in the forums. Many users run
npm audit fixbecause this is displayed when installing mm.The current installation command in the docs is
npm install --only=prod --omit=dev, not very handy.So I thought of simplifying installation and
npm run install-mm(andnpm run install-mm:devfor install with devDependencies)--no-audit --no-fund --no-update-notifierfor less noise (also to vender and fonts install)With this the audit and npm update messages are gone. The new command is faster (without audit) and this will (hopefully) produce less support because running the audit fix command (by the user) often destroyed a running installation.
Other installation processes as @sdetweil's install scripts or the docker image could also use the new scripts.
I'm open for renaming the new scripts or better ideas.
If this is accepted/merged I will add a PR to the documentation repo for updating the installation command.