Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2890 +/- ##
========================================
Coverage 63.82% 63.82%
========================================
Files 9 9
Lines 293 293
========================================
Hits 187 187
Misses 106 106 Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
the failed test (electron executable not found) seems unrelated to your changes (don't know what happened there on the github machine). You can trigger the tests again by pushing a new commit (e.g. by removing the line break in the changelog). |
MikeBishop
force-pushed
the
showTimeToday
branch
from
3dc8261 to
be97611
Compare
| timeWrapper.innerHTML = this.capFirst( | ||
| moment(event.startDate, "x").calendar(null, { | ||
| sameDay: "[" + this.translate("TODAY") + "]", | ||
| sameDay: this.config.showTimeToday ? "LT" : "[" + this.translate("TODAY") + "]", |
There was a problem hiding this comment.
So if this is set, it displays "LT"? How does that string show up on the MM?
There was a problem hiding this comment.
It passes LT as the format string to Moment; compare the default value of dateEndFormat or other explicit uses here and here. LT renders time according to the current locale, e.g. "2:53 PM", "14:53", etc.
|
Awesome! Would you mind adding info about this feature via a PR on: https://github.com/MichMich/MagicMirror-Documentation Thanks! :) |
5 participants
When I was trying to move to the "relative" timeFormat, I found that while relative was useful for events that were approaching -- the baseball game is on Saturday, etc. -- present-day events in relative format were at best annoying.
This adds an additional option that displays non-full-day events with an absolute time on the current day, while leaving the relative behavior alone for other days. (Full-day events continue to display "Today".)