English doesn't have a "day after tomorrow" word#2889
English doesn't have a "day after tomorrow" word#2889MichMich merged 3 commits intoMagicMirrorOrg:developfrom
Conversation
|
Hm. So I see that the tests enforce that all translated items must be in both the base language and all other languages. While that's admirable for coverage, in this instance the code explicitly checks whether the term exists and moves on properly if it's absent. Is there a way to explicitly allow this translation not to exist, perhaps by having it present but with a null value? (Edit: From a cursory inspection of |
|
looking into the translation test: So if you delete one key, we have to use another language. Tested with change in this line change in this line and the test will work again. May add some comments why this was changed ... |
Codecov Report
@@ Coverage Diff @@
## develop #2889 +/- ##
========================================
Coverage 63.82% 63.82%
========================================
Files 9 9
Lines 293 293
========================================
Hits 187 187
Misses 106 106 Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
That appears to have worked -- thank you! |
|
Thanks! Sorry for the slow merge. Was enjoying a sunny holiday. :) |
|
No worries at all! (For anyone's general edification, English does technically have such a word -- "overmorrow" -- but it hasn't been in common use since Middle English.) |
English doesn't have a word for the day after the day after today. "In 2 days" doesn't align with the behavior around
relativeformatting for non-full-day events -- that uses "today," "tomorrow," and then goes to days of the week.Having played around with different formats, I've concluded that "In 2 days" is an odd-ball that shows up here only(?) for English. Many languages have a word for that; obviously the code should continue to accommodate those languages.
The simplest "fix" then is simply to drop this term from
en.json, as the code already handles theDAYAFTERTOMORROWfield not being defined for a given language. So let's just let English be such a language.