fix newsfeedfetcher using correct stream version#2857
Merged
MichMich merged 1 commit intoMagicMirrorOrg:developfrom Jun 4, 2022
Merged
fix newsfeedfetcher using correct stream version#2857MichMich merged 1 commit intoMagicMirrorOrg:developfrom
MichMich merged 1 commit intoMagicMirrorOrg:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2857 +/- ##
========================================
Coverage 63.82% 63.82%
========================================
Files 9 9
Lines 293 293
========================================
Hits 187 187
Misses 106 106 Continue to review full report at Codecov.
|
rejas
approved these changes
May 30, 2022
Collaborator
Author
|
@MichMich can we get this merged? Because the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
correction for #2855
The stream format has changed in the node-internal fetch method which breaks the newsfeed module (when using node 18).