use internal fetch function of node#2855
Merged
MichMich merged 3 commits intoMagicMirrorOrg:developfrom May 28, 2022
Merged
Conversation
…rary if node version >= `v18`
# Conflicts: # CHANGELOG.md
Codecov Report
@@ Coverage Diff @@
## develop #2855 +/- ##
===========================================
- Coverage 64.80% 63.82% -0.99%
===========================================
Files 8 9 +1
Lines 287 293 +6
===========================================
+ Hits 186 187 +1
- Misses 101 106 +5
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #2649
With Node >=
v18comes an internal fetch method. This PR centralizes the use offetchin a new modulejs/fetch.jsand uses the internal fetch function of node instead externalnode-fetchlibrary if node version >=v18.