Skip to content

added a new config option httpHeaders used by helmet#2850

Merged
MichMich merged 2 commits intoMagicMirrorOrg:developfrom
khassel:iframe
May 18, 2022
Merged

added a new config option httpHeaders used by helmet#2850
MichMich merged 2 commits intoMagicMirrorOrg:developfrom
khassel:iframe

Conversation

@khassel
Copy link
Collaborator

@khassel khassel commented May 13, 2022

Added a new config option httpHeaders used by helmet (see https://helmetjs.github.io/). You can now set own httpHeaders which will override the defaults in js/defauls.js which is useful e.g. if you want to embed MagicMirror into annother website (solves #2847).

@codecov-commenter
Copy link

Codecov Report

Merging #2850 (3b55886) into develop (d730dd0) will decrease coverage by 0.34%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2850      +/-   ##
===========================================
- Coverage    65.15%   64.80%   -0.35%     
===========================================
  Files            8        8              
  Lines          287      287              
===========================================
- Hits           187      186       -1     
- Misses         100      101       +1     
Impacted Files Coverage Δ
js/defaults.js 85.71% <ø> (ø)
js/server.js 66.21% <100.00%> (-1.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d730dd0...3b55886. Read the comment docs.

@khassel
Copy link
Collaborator Author

khassel commented May 13, 2022

@rejas @MichMich I tried to avoid upcoming merge conflicts by adding a blank line in CHANGELOG.md but this was rejected by prettier. Can we exclude this file from the prettier check, you can always run prettier before each release to fix style errors ...

@MichMich MichMich merged commit cbda20f into MagicMirrorOrg:develop May 18, 2022
@khassel khassel deleted the iframe branch May 19, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants