added a new config option httpHeaders used by helmet#2850
Merged
MichMich merged 2 commits intoMagicMirrorOrg:developfrom May 18, 2022
Merged
added a new config option httpHeaders used by helmet#2850MichMich merged 2 commits intoMagicMirrorOrg:developfrom
httpHeaders used by helmet#2850MichMich merged 2 commits intoMagicMirrorOrg:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2850 +/- ##
===========================================
- Coverage 65.15% 64.80% -0.35%
===========================================
Files 8 8
Lines 287 287
===========================================
- Hits 187 186 -1
- Misses 100 101 +1
Continue to review full report at Codecov.
|
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new config option
httpHeadersused by helmet (see https://helmetjs.github.io/). You can now set own httpHeaders which will override the defaults injs/defauls.jswhich is useful e.g. if you want to embed MagicMirror into annother website (solves #2847).