Skip to content

Update github actions#2844

Merged
MichMich merged 4 commits intoMagicMirrorOrg:developfrom
rejas:actions
May 18, 2022
Merged

Update github actions#2844
MichMich merged 4 commits intoMagicMirrorOrg:developfrom
rejas:actions

Conversation

@rejas
Copy link
Collaborator

@rejas rejas commented May 2, 2022

Use latest versions of the github actions
Use node 18 when running tests

@@ -18,7 +18,7 @@ jobs:
node-version: [14.x, 16.x, 17.x]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still v17?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thx!

@codecov-commenter
Copy link

Codecov Report

Merging #2844 (bb1d343) into develop (d730dd0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2844   +/-   ##
========================================
  Coverage    65.15%   65.15%           
========================================
  Files            8        8           
  Lines          287      287           
========================================
  Hits           187      187           
  Misses         100      100           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d730dd0...bb1d343. Read the comment docs.

@khassel
Copy link
Collaborator

khassel commented May 2, 2022

btw I moved my develop images from node v17 to v18 an hour before, works.

@MichMich MichMich merged commit 3e65ac6 into MagicMirrorOrg:develop May 18, 2022
@rejas rejas deleted the actions branch May 18, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants