Skip to content

Fix problems with non latin fonds caused by updating to fontsource#2836

Merged
MichMich merged 1 commit intoMagicMirrorOrg:developfrom
khassel:fix-non-latin
Apr 9, 2022
Merged

Fix problems with non latin fonds caused by updating to fontsource#2836
MichMich merged 1 commit intoMagicMirrorOrg:developfrom
khassel:fix-non-latin

Conversation

@khassel
Copy link
Collaborator

@khassel khassel commented Apr 5, 2022

fixes #2835

@khassel khassel marked this pull request as draft April 5, 2022 18:12
@khassel
Copy link
Collaborator Author

khassel commented Apr 5, 2022

Need feedback to this one. I had to substitue -latin- with -all- for fixing the non latin fonds.

But there are no woff2 files for -all- so I removed the links to woff2. Reading about this woff2 seems to be the preferred format. Any better ideas?

@MichMich
Copy link
Collaborator

MichMich commented Apr 5, 2022

As long as it's supported by electron it seems fine by me.

@khassel
Copy link
Collaborator Author

khassel commented Apr 5, 2022

tested this with electron, but must be tested anyway by non-latin users ...

@khassel khassel marked this pull request as ready for review April 5, 2022 19:13
@rejas
Copy link
Collaborator

rejas commented Apr 5, 2022

During standard web-developmet, woff2 would indeed be preferred due to size improvements. But I guess here we can ignore that :-)

@MichMich MichMich merged commit 439690b into MagicMirrorOrg:develop Apr 9, 2022
@MichMich
Copy link
Collaborator

MichMich commented Apr 9, 2022

I merged this to see if this will cause issues. We can always revert if someone runs into issues.

@khassel khassel deleted the fix-non-latin branch April 9, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants