toggle pointer-events with suspension#2827
Merged
MichMich merged 1 commit intoMagicMirrorOrg:developfrom Mar 26, 2022
Merged
Conversation
rejas
approved these changes
Mar 26, 2022
Collaborator
rejas
left a comment
rejas
left a comment
There was a problem hiding this comment.
Thanks, looks ok although I cannot test it myself. You will need to add a CHANGELOG entry though before it gets merged.
Codecov Report
@@ Coverage Diff @@
## develop #2827 +/- ##
========================================
Coverage 65.26% 65.26%
========================================
Files 8 8
Lines 285 285
========================================
Hits 186 186
Misses 99 99 Continue to review full report at Codecov.
|
Contributor
Author
|
Sure, thanks. |
Collaborator
|
You can just add them to the wiki. It's open for everybody to edit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I added two classes for the hidden/visible modules to toggle the pointer-events with the new
.hiddenclass.Further I removed the one with the universal selector, which made hidden modules and just anything in them stealing pointer events, if they were placed in any fullscreen area.