Skip to content

Add missing CS translations#2819

Merged
MichMich merged 18 commits intoMagicMirrorOrg:developfrom
krekos:patch-1
Apr 1, 2022
Merged

Add missing CS translations#2819
MichMich merged 18 commits intoMagicMirrorOrg:developfrom
krekos:patch-1

Conversation

@krekos
Copy link
Contributor

@krekos krekos commented Mar 12, 2022

Hello and thank you for wanting to contribute to the MagicMirror project

Please make sure that you have followed these 4 rules before submitting your Pull Request:

  1. Base your pull requests against the develop branch.

  2. Include these infos in the description:

  • Does the pull request solve a related issue?
  • If so, can you reference the issue like this Fixes #<issue_number>?
  • What does the pull request accomplish? Use a list if needed.
  • If it includes major visual changes please add screenshots.

  1. Please run npm run lint:prettier before submitting so that
    style issues are fixed.

  2. Don't forget to add an entry about your changes to
    the CHANGELOG.md file.

Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of develop before creating a
pull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.

Thanks again and have a nice day!

@KristjanESPERANTO
Copy link
Collaborator

KristjanESPERANTO commented Mar 12, 2022

Great, thanks 🙂 Can you also update the CHANGELOG.md?

KristjanESPERANTO and others added 2 commits March 12, 2022 13:03
@KristjanESPERANTO
Update German translation
468bf1d 
- Remove unnecessary HTML Entities
- Completion of missing translations
- Rewordings
- Corrections of typography mistakes
@MichMich
Merge pull request MagicMirrorOrg#2820 from KristjanESPERANTO/german
d0565a1
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2022 •
edited
Loading

Codecov Report

Merging #2819 (16bf19d) into develop (a6cbc9f) will decrease coverage by 3.41%.
The diff coverage is 17.39%.

@@             Coverage Diff             @@
##           develop    #2819      +/-   ##
===========================================
- Coverage    68.67%   65.26%   -3.42%     
===========================================
  Files            8        8              
  Lines          265      285      +20     
===========================================
+ Hits           182      186       +4     
- Misses          83       99      +16
Impacted Files Coverage Δ
js/app.js 59.66% <0.00%> (ø)
js/defaults.js 85.71% <ø> (ø)
js/deprecated.js 100.00% <ø> (ø)
js/logger.js 52.63% <ø> (ø)
js/utils.js 100.00% <ø> (ø)
modules/default/defaultmodules.js 100.00% <ø> (ø)
js/server.js 67.56% <19.04%> (-17.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6cbc9f...16bf19d. Read the comment docs.

@krekos
Copy link
Contributor Author

krekos commented Mar 22, 2022 •
edited
Loading

@KristjanESPERANTO Hello, yes, but what Version number and release date i should use? 2.18.1 and for date 1st of next month?

I probably forked Master insted of Develop and i cannot sync changes, so i didnt see the new Changlog. Will you merge the PR with changing the Changelog in another PR, or should i close this PR and make a new one?

@rejas
Copy link
Collaborator

rejas commented Mar 22, 2022

I probably forked Master insted of Develop and i cannot sync changes, so i didnt see the new Changlog. Will you merge the PR with changing the Changelog in another PR, or should i close this PR and make a new one?

@MichMich might be able to do that and update your PR before merging it

@MichMich
Copy link
Collaborator

MichMich commented Mar 22, 2022

I'll merge it! 👍🏻

@krekos
Copy link
Contributor Author

krekos commented Mar 30, 2022

Thnak you. And sorry for more work :)

@MichMich MichMich merged commit 69b2dd6 into MagicMirrorOrg:develop Apr 1, 2022
@snyk-bot snyk-bot mentioned this pull request Apr 29, 2023
Open
@ferreiramarcelo ferreiramarcelo mentioned this pull request Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@krekos @KristjanESPERANTO @codecov-commenter @rejas @MichMich @shin10 @sdetweil @khassel