Skip to content

Weather provider weatherflow#2815

Merged
MichMich merged 6 commits intoMagicMirrorOrg:developfrom
10bias:weather-provider-weatherflow
Mar 11, 2022
Merged

Weather provider weatherflow#2815
MichMich merged 6 commits intoMagicMirrorOrg:developfrom
10bias:weather-provider-weatherflow

Conversation

@10bias
Copy link
Contributor

@10bias 10bias commented Feb 21, 2022

Hi everyone,

i added a weather provider for weatherflow (https://weatherflow.com/)

best regards

@khassel
Copy link
Collaborator

khassel commented Feb 21, 2022

Thank you for the contribution.

An additional PR in the documentation repo would be helpful, a new section in this document for the new provider.


/* MagicMirror²
* Module: Weather
* Provider: Dark Sky
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong name :-)

@rejas
Copy link
Collaborator

rejas commented Feb 22, 2022

Also you probably need to do a "npm run lint:prettier" and push the changes so that the linter wont complain once @MichMich approves the workflows

@10bias
Copy link
Contributor Author

10bias commented Feb 22, 2022

Thanks for the hints. I fixed the copy and paste mistake in the comment and run the lint. I also added a documentation for the provider und created a pr: MagicMirrorOrg/MagicMirror-Documentation#109

@10bias
Copy link
Contributor Author

10bias commented Feb 25, 2022

I have just add a fix with the sunrise.

stationid: ""
},

units: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those seem unused?

@10bias
Copy link
Contributor Author

10bias commented Feb 26, 2022

@rejas oh yes, i have added a functionality to switch between the units. I hope the imperial units a correct. Some researches didn't deliverd a clear result. If there is something wrong, please let me know.

@rejas
Copy link
Collaborator

rejas commented Mar 5, 2022

Thx for the info. Cant tell if yomethings wrong, got no api keys :-) Since this a fresh provider, I dont mind merging it and see if it works "in the wild" :-)

@codecov-commenter
Copy link

Codecov Report

Merging #2815 (9056aba) into develop (81ae95e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2815   +/-   ##
========================================
  Coverage    64.91%   64.91%           
========================================
  Files            8        8           
  Lines          285      285           
========================================
  Hits           185      185           
  Misses         100      100           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81ae95e...9056aba. Read the comment docs.

@MichMich
Copy link
Collaborator

Thanks for your contribution! My apologies for my slow response. Life got in the way.

@MichMich MichMich merged commit e12f57d into MagicMirrorOrg:develop Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants