Skip to content

Revive contribution link#2809

Merged
MichMich merged 2 commits intoMagicMirrorOrg:developfrom
Nerfzooka:patch-1
Mar 11, 2022
Merged

Revive contribution link#2809
MichMich merged 2 commits intoMagicMirrorOrg:developfrom
Nerfzooka:patch-1

Conversation

@Nerfzooka
Copy link
Contributor

Not sure if this is the contribution page that was intended, but the old link was pretty dead (https://docs.magicmirror.builders/getting-started/contributing.html).

Hello and thank you for wanting to contribute to the MagicMirror project

Please make sure that you have followed these 4 rules before submitting your Pull Request:

  1. Base your pull requests against the develop branch.

  2. Include these infos in the description:

  • Does the pull request solve a related issue?
  • If so, can you reference the issue like this Fixes #<issue_number>?
  • What does the pull request accomplish? Use a list if needed.
  • If it includes major visual changes please add screenshots.
  1. Please run npm run lint:prettier before submitting so that
    style issues are fixed.

  2. Don't forget to add an entry about your changes to
    the CHANGELOG.md file.

Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of develop before creating a
pull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.

Thanks again and have a nice day!

@codecov-commenter
Copy link

Codecov Report

Merging #2809 (7cab6eb) into develop (dcaa352) will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2809      +/-   ##
===========================================
+ Coverage    64.91%   65.26%   +0.35%     
===========================================
  Files            8        8              
  Lines          285      285              
===========================================
+ Hits           185      186       +1     
+ Misses         100       99       -1     
Impacted Files Coverage Δ
js/server.js 67.56% <0.00%> (+1.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcaa352...7cab6eb. Read the comment docs.

@MichMich
Copy link
Collaborator

Thanks for your contribution! My apologies for my slow response. Life got in the way.

@MichMich MichMich merged commit a52c68d into MagicMirrorOrg:develop Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants