You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have several modules that provide alternate displays for calendar events, and currently, if I want the calendar module to return all of the future events for the current month (for my MMM-MonthlyCalendar module), then I need to configure maximumEvents to be large enough that the calendar module itself needs to be hidden. Instead, the configured display limits should only be imposed when generating the list of events to display, not when fetching events from configured calendars.
I understand the need and it's fine to implement. But I'm not a big fan of the forDisplay attribute since it doesn't tell what will happen if it's set to true. Maybe rename it to something like limitNumberOfEntries?
@MichMich the test fail is unrelated to the code changes, same test ran locally on my machine and in all tests except node 14 (by now I think the vm running the tests was extremly slow but if this occurs again we have to increase timeout).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have several modules that provide alternate displays for calendar events, and currently, if I want the calendar module to return all of the future events for the current month (for my MMM-MonthlyCalendar module), then I need to configure maximumEvents to be large enough that the calendar module itself needs to be hidden. Instead, the configured display limits should only be imposed when generating the list of events to display, not when fetching events from configured calendars.