Add absolute dates to weather forecast#2764
Conversation
Add an absolute date option to the weather module's forecast.
Update CHANCEGLOG
|
Nice idea! @rejas made a valid point. Also: since this is a new feature, don't forget to send a PR to the docs repo after merge. :) |
Set absoluteDates default to false
oraclesean
left a comment
oraclesean
left a comment
There was a problem hiding this comment.
Change made to weather.js, thanks for catching that!
|
Nice. Now it would be awesome if you could add a testcase for that. Think you can do it or do you need help? |
|
@rejas yes I'd appreciate some guidance for a test case. JS is not my ninja area 😄 |
Codecov Report
@@ Coverage Diff @@
## develop #2764 +/- ##
========================================
Coverage 68.67% 68.67%
========================================
Files 8 8
Lines 265 265
========================================
Hits 182 182
Misses 83 83 Continue to review full report at Codecov.
|
| colored: false, | ||
| showFeelsLike: true | ||
| showFeelsLike: true, | ||
| absoluteDates: false |
There was a problem hiding this comment.
if this is a property for the forecast, shouldn't this inserted in weatherforecast.js instead?
There was a problem hiding this comment.
I thought the current and forecast modules were deprecated in favor of the standalone weather module.
There was a problem hiding this comment.
ups, sorry for the noise, was irritated when looking in the tests (theoretically I should know this ...)
|
wrote a test for this, will provide a PR when this is merged. |
|
Done! |
5 participants
Does the pull request solve a related issue?
No
If so, can you reference the issue like this
Fixes #<issue_number>?N/A
What does the pull request accomplish? Use a list if needed.
Add a Boolean configuration option
absoluteDatestomodules/default/weatherto allow weather forecast dates to be formatted as absolute (MON, TUE) or relative (TODAY, TOMORROW).If it includes major visual changes please add screenshots.
N/A