Allow dangerouslyDisablingAutoEscaping in newsfeed items#2736
Merged
MichMich merged 3 commits intoMagicMirrorOrg:developfrom Dec 21, 2021
Merged
Allow dangerouslyDisablingAutoEscaping in newsfeed items#2736MichMich merged 3 commits intoMagicMirrorOrg:developfrom
MichMich merged 3 commits intoMagicMirrorOrg:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2736 +/- ##
========================================
Coverage 69.08% 69.08%
========================================
Files 8 8
Lines 262 262
========================================
Hits 181 181
Misses 81 81 Continue to review full report at Codecov.
|
Collaborator
|
Love the variableName. 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the newfeed might encode html tags and such (german umlauts for eaxmple) which the nunjuck templating would escape again so that the text looks like garbage.
This is helpful in preventing malicious code to be send to the mirror but the user might now disable this behaviour with the new config option "dangerouslyDisableAutoEscaping"
Fixes #2712