Issue translate encoded html#2427
Merged
MichMich merged 7 commits intoMagicMirrorOrg:developfrom Jan 21, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2427 +/- ##
========================================
Coverage 39.42% 39.42%
========================================
Files 20 20
Lines 1608 1608
========================================
Hits 634 634
Misses 974 974 Continue to review full report at Codecov.
|
Contributor
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't create an issue for this, I jumped right to PR, but happy to go back and create the issue if needed.
Problem: The translated string of
"LOADING": "Loading …",shows up exactly like that instead ofLoading ...when you use{{ "LOADING" | translate }}in a nunjucks template.I've marked all translated strings as 'safe' so they will be properly decoded now. Since it's the input from a known file this seems safe to me.
Alternatives would be to manually mark all
| translateas| translate | safeto ensure there are no encoded characters in it, and that didn't seem great.